Merged
Conversation
Contributor
Author
|
CI cached a bug it seams. |
Member
|
Don't worry about, that repo is just outdated. |
Jake-Shadle
approved these changes
Oct 3, 2020
Member
Jake-Shadle
left a comment
There was a problem hiding this comment.
Thanks for the PR! I've been bad about merging PRs so I'll just merge this now, can improve it later. 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115.
As said in the linked issue we should discus if this is enough normalization. Also I am not sure if it is a good idea to change values in the validation step.
Besides do the normalization I also adapted the test file so that the new feature will be tested. This test fails with the old version version of cargo-deny and passes with the changes in this PR.