Conversation
Adjust `buf` in `discord_create_interaction_response()` to be the size of 16384 like the others
"Succesfully started a Discord session!" is missing a 's'
Adding the PostgreSQL & sqlite3 databases guides to Concord guides. Co-authored-by: HackerSmacker Co-authored-by: Lucas Müller <muller.lucas@hotmail.com>
…or Concord cross-compilation changes)
fix serializing for 'struct discord_request_guild_members' Part of #135
Fix for bug where websockets.c would try to send CLOSE to websocket when already disconnected in TLS errors Co-authored-by: Lucas Müller <lucas@muller.codes>
Adding the guide for the usage of the scheduler event, and how to parse the json from it.
HackerSmacker
approved these changes
May 14, 2023
Collaborator
HackerSmacker
left a comment
HackerSmacker
left a comment
There was a problem hiding this comment.
I think this is definitely a good documentation update, and, I think that the code updates are good.
A few things I've got on my roadmap for the future:
- my fixes to get Concord compiling on OpenVMS, just for fun
- drop dependence on CWS with a suitable replacement, not just a PoC
- add guides for "other" databases, such as MySQL and cloud DBs (as these are pretty popular nowadays)
ThePedroo
approved these changes
May 14, 2023
Contributor
ThePedroo
left a comment
ThePedroo
left a comment
There was a problem hiding this comment.
Amazing! Also, something that would be useful for the future would be a list of supported & unsupported things (like sharding), so new people won't be confused
Use QuerieC library to improve query system. Co-authored-by: Lucas Müller <lucas@muller.codes>
lcsmuller
force-pushed
the
dev
branch
2 times, most recently
from
c8fa148 to
44f26a6
Compare
Bad typing for `resolved` object
Accessing a NULL ptr will segfault the bot, dealbreaker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notice
to test it before making changes to Concord.
This PR introduces a couple of things:
Features
discord_shutdown_async(), and adddiscord_shutting_down()to check whether the client is currently in the process of shutting downBug fixes
NULLcheck when convertingjson_chartypes to JSONReferences
#140