docs(guide): add env guide#121
Merged
lcsmuller merged 1 commit intoCogmasters:masterfrom Oct 19, 2022
Merged
Conversation
lcsmuller
reviewed
Oct 15, 2022
lcsmuller
reviewed
Oct 15, 2022
7b135eb to
b297e4b
Compare
lcsmuller
approved these changes
Oct 15, 2022
Contributor
|
env vars are also supported in the init functions |
Contributor
Author
|
Is there a place saying how to use it and giving details of it so I can include on it? |
Collaborator
HackerSmacker
left a comment
There was a problem hiding this comment.
Alright, I mentioned a few things that you probably want to change, and added a ksh and Bash style example.
cae6b75 to
fcd9d0c
Compare
Contributor
Author
|
Done @Anotra, I've just added an example of how to retrieve the value of an env variable in the discord(_config)_init. Are you able to review it? It would be awesome |
lcsmuller
reviewed
Oct 19, 2022
lcsmuller
reviewed
Oct 19, 2022
Adding the "env vars with concord" guide. References Cogmasters#109 Co-authored-by: Lucas Müller <lucas@muller.codes> Co-authored-by: HackerSmacker
fcd9d0c to
ecf8f12
Compare
lcsmuller
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notice
to test it before making changes to Concord.
What?
Adding the "Setting up with
envvariables" guide.Why?
Because it was requested on issue 109.