added VZNetworkBlockDeviceStorageDeviceAttachment#156
added VZNetworkBlockDeviceStorageDeviceAttachment#156Code-Hex merged 6 commits intoCode-Hex:mainfrom
Conversation
|
@Code-Hex Is the failing CI something I should look into? I couldn't determine whether the cancelled operation was a CI failure, or whether the CI pipeline was externally cancelled. |
virtualization_14.m
Outdated
| #ifdef INCLUDE_TARGET_OSX_14 | ||
| if (@available(macOS 14, *)) { | ||
| NSString *urlNSString = [NSString stringWithUTF8String:uri]; | ||
| NSURL *url = [[NSURL alloc] initWithString:urlNSString]; |
There was a problem hiding this comment.
You could also use NSURL URLWithString:urlNSString
With NSURL alloc, I believe url should be in a @autoreleasepool block or it will leak memory.
No idea if memory needs to be released with URLWithString, I don't know well enough how objc memory management works :-/
Signed-off-by: Abiola Ibrahim <git@abiosoft.com>
add support for nested virtualization
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
CI: remove old versions and increase timeout
|
This repo doesn't seem actively maintained currently. Would you be interested in submitting your PR to our fork? https://github.com/lima-vm/vz |
Signed-off-by: Arran Walker <arran.walker@fiveturns.org>
|
@AkihiroSuda I invited you to maintain this repo 🙏 |
|
Thanks! |
Further to #142, this adds VZNetworkBlockDeviceStorageDeviceAttachment support.
This PR lacks setting a delegate to monitor state changes to the attachment, mostly because I couldn't figure out the best way to integrate this and it would probably lead to a much larger PR. Hopefully that can be done in a follow-up.
I've updated the MacOS application to ease testing. You can serve an existing raw disk within the bundle directory with
qemu-nbd:And then run:
The
-installoption also works well with this argument if you serve a disk created withqemu-img.This is great news as it gives access to
qemu'sqcow2format and linked disks functionality.Relates to #143