panic: runtime/cgo: misuse of an invalid Handle on RequestStop and waiting for vm stopped state

[balajiv113]

Describe the bug
Issue is similar to the #119. But now it happens mainly during RequestStop and waiting for vm state to change to stop

To Reproduce
Steps to reproduce the behavior:

1. limactl start template://experimental/vz
2. limactl stop vz
3. Notice panic happened

Expected behavior
No panic occurs during stop

Environment that you use to compile (please complete the following information):

• Xcode version: [Xcode 14.1 Build version 14B47b]
• macOS Version: [ProductName: macOS, ProductVersion: 13.2, BuildVersion: 22D49]
• mac architecture: [x86_64]
• Go Version: [go version go1.20.1 darwin/amd64]

Additional context
lima-vm/lima#1381

[Code-Hex]

I can handle it next month... 🙏
sorry... I'm very busy now

[Code-Hex]

btw, is this using Kernel which is supported RequestStop?

[pmalek]

I also observe this on Mac M1 Max (Ventura 13.2.1) arm64 when running colima v0.5.4

{"level":"error","msg":"dhcp: unhandled message type: RELEASE","time":"2023-03-15T11:14:23+01:00"}
panic: runtime/cgo: misuse of an invalid Handle

goroutine 17 [running, locked to thread]:
runtime/cgo.Handle.Value(...)
        /opt/homebrew/Cellar/go/1.20.1/libexec/src/runtime/cgo/handle.go:124
github.com/Code-Hex/vz/v3.changeStateOnObserver(0x0, 0x14000002680?)
        /Users/USER/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/!code-!hex/vz/v3@v3.0.4/virtualization.go:160 +0xe8

[ryancurrah]

I am running Ventura 13.2.1 (22D68), CPU Apple M1 Max, from the Apple docs RequestStop seems to be supported since macOS 11.0+.

panic: runtime/cgo: misuse of an invalid Handle

goroutine 17 [running, locked to thread]:
runtime/cgo.Handle.Value(...)
        /opt/homebrew/Cellar/go/1.20.1/libexec/src/runtime/cgo/handle.go:124
github.com/Code-Hex/vz/v3.changeStateOnObserver(0x0, 0x14000002680?)
        /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/!code-!hex/vz/v3@v3.0.4/virtualization.go:160 +0xe8

[Code-Hex]

@pmalek @ryancurrah I'm sorry I didn't notice!
I will check it on Saturday!

@ryancurrah I know supported the RequestStop API from macOS 11.0+. I mentioned to Linux Kernel one.
#124 (comment)

[ryancurrah]

@ryancurrah I know supported the RequestStop API from macOS 11.0+. I mentioned to Linux Kernel one.
#124 (comment)

Ah that makes more sense now. Thanks!

[Code-Hex]

I'm working this!

[Code-Hex]

I've probably fixed it. I don't have the code to reproduce it at hand, which is worrying, but I'll see how this goes!

If there are still problems, we expect the issue to be opened again with reproduced code.

[Code-Hex]

Btw, I just published the latest version for this

https://github.com/Code-Hex/vz/releases/tag/v3.0.5

[balajiv113]

Thank you for the fix :)
I can confirm that this fixes panic that happened with in StateChangeHandler()

But even then a panic occurs if we call Status() directly after the RequestStop() is called. But unfortunately i still don't have vz specific reproducible code. So i will keep this issue closed.

PS: Lima issue is hopefully fixed now by not using Status() method lima-vm/lima#1494

[Code-Hex]

@balajiv113 Oh...

What does it mean when we know this sequence and you don't reproduce it? 🤔

But even then a panic occurs if we call Status() directly after the RequestStop() is called. But unfortunately i still don't have vz specific reproducible code