Skip to content

url.Parse adoption from Go 1.25.7#1787

Merged
kavirajk merged 2 commits intoClickHouse:mainfrom
M0rdecay:feature/url-parse-adoption
Mar 16, 2026
Merged

url.Parse adoption from Go 1.25.7#1787
kavirajk merged 2 commits intoClickHouse:mainfrom
M0rdecay:feature/url-parse-adoption

Conversation

@M0rdecay
Copy link
Copy Markdown
Contributor

@M0rdecay M0rdecay commented Mar 6, 2026

Summary

Since Go 1.26 intentionally does not support the ability to specify multiple hosts in a URL, which is required for HA mode, the Parse function was adopted from Go 1.25.7.

Checklist

Delete items not relevant to your PR:

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 6, 2026

CLA assistant check
All committers have signed the CLA.

@M0rdecay M0rdecay marked this pull request as ready for review March 6, 2026 18:52
Copy link
Copy Markdown
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick PR @M0rdecay LGTM.

@kavirajk kavirajk merged commit 93e89be into ClickHouse:main Mar 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants