Skip to content

fix: Excel export prohibits inputting external links or formulas#3105

Merged
shaohuzhang1 merged 1 commit intomainfrom
pr@main@fix_excel_export
May 19, 2025
Merged

fix: Excel export prohibits inputting external links or formulas#3105
shaohuzhang1 merged 1 commit intomainfrom
pr@main@fix_excel_export

Conversation

@shaohuzhang1
Copy link
Contributor

fix: Excel export prohibits inputting external links or formulas

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 19, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cell.value = col
# 创建HttpResponse对象返回Excel文件
return workbook

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no immediate irregularities or potential issues in the provided code. There is one suggestion for code optimization:

# Suggestion:
# Move the translation imports above other dependencies to avoid circular imports.

This improvement will improve maintainability by reducing the likelihood of a conflict between Django's ORM and the django.utils module when loading translations.

@shaohuzhang1 shaohuzhang1 merged commit 5e0d804 into main May 19, 2025
4 of 5 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@main@fix_excel_export branch May 19, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant