fix: Cannot copy applications with opening statement characters exceeding 4096#3022
fix: Cannot copy applications with opening statement characters exceeding 4096#3022shaohuzhang1 merged 1 commit intomainfrom
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| prologue = serializers.CharField(required=False, allow_null=True, allow_blank=True, max_length=102400, | ||
| error_messages=ErrMessage.char(_("Opening remarks"))) | ||
| dataset_id_list = serializers.ListSerializer(required=False, child=serializers.UUIDField(required=True), | ||
| error_messages=ErrMessage.list(_("Related Knowledge Base")) |
There was a problem hiding this comment.
There are a couple of issues in this code snippet:
- The
allow_blank=Trueparameter is typically used with fields that accept Unicode strings (like text areas) instead of character strings (like single-line text). So the appropriate field type should be something likeCharField, notSerializers.CharField. You can remove theallow_blank=Trueif you intended to use something else.
Here's an optimized version assuming UTF-8 encoding:
class Edit(serializers.Serializer):
historical_chat_count = serializers.IntegerField(
required=False,
default=0,
min_value=0,
max_value=1024,
error_messages=dict(min_value=_('Minimum value: 0'),
max_value=_('Maximum value: 1024'))
)
prologue = serializers Charfield(
required=False,
blank=True,
max_length=102400, # Assuming maximum length of utf-8 characters
error_messages=dict(required=_('Prologue is required'))
)
dataset_id_list = serializers.ListSerializer(
required=False,
child=serializers.UUIDField(),
allow_null=True,
error_messages=dict(max_length=_('Dataset ID list cannot be longer than allowed'))
)Additionally, ensure all other fields follow the same logic as well, using the correct fields from Django REST Framework and adhering to best naming conventions for variables and attributes within classes.
fix: Cannot copy applications with opening statement characters exceeding 4096