Skip to content

Commit 7abedd5

Browse files
author
Tom Seddon
committed
Add experimental macOS CI runner failure stuff.
1 parent 48e0cc2 commit 7abedd5

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

Makefile.osx.mak

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ github_ci_macos_homebrew_ffmpeg:
5050
.PHONY:_github_ci_macos_release
5151
_github_ci_macos_release: export PYTHONUNBUFFERED=1
5252
_github_ci_macos_release:
53-
-$(PYTHON3) "./etc/release/release.py" --verbose $(TARGET_ARGS) --timestamp=$(shell $(PYTHON3) "./etc/release/release2.py" print-timestamp) --gh-release $(shell $(PYTHON3) "./etc/release/release2.py" print-suffix) --ctest-jobs=1 --ctest-output-on-failure
54-
./build/_Rel.f.osx/src/beeb/tests/test_beeb -T "standard.*"
53+
-$(PYTHON3) "./etc/release/release.py" --verbose $(TARGET_ARGS) --timestamp=$(shell $(PYTHON3) "./etc/release/release2.py" print-timestamp) --gh-release $(shell $(PYTHON3) "./etc/release/release2.py" print-suffix) --ctest-output-on-failure --ctest-timeout 90
54+
./build/_Rel.f.osx/src/beeb/tests/test_beeb --verbose -T "standard.*"
5555

5656
.PHONY:github_ci_macos_x64
5757
github_ci_macos_x64:

src/beeb/tests/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ b2_target_boilerplate(test_beeb SANITIZERS)
4444

4545
function(add_test_beeb_category category)
4646
add_test(NAME beeb/test_beeb_${category}
47-
COMMAND $<TARGET_FILE:test_beeb> -T "${category}.*")
47+
COMMAND $<TARGET_FILE:test_beeb> --verbose -T "${category}.*")
4848
endfunction()
4949

5050
add_test_beeb_category(standard)

src/beeb/tests/test_beeb.cpp

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1811,6 +1811,7 @@ class VideoNuLATest : public Test {
18111811
//////////////////////////////////////////////////////////////////////////
18121812

18131813
struct Options {
1814+
bool verbose = false;
18141815
std::vector<std::string> test_name_strs;
18151816
std::vector<std::regex> test_name_regexes;
18161817
bool list = false;
@@ -1828,6 +1829,7 @@ static Options GetOptions(int argc, char *argv[]) {
18281829

18291830
std::vector<std::string> test_name_patterns;
18301831

1832+
p.AddOption('v', "verbose").SetIfPresent(&options.verbose).Help("be more verbose");
18311833
p.AddOption('t', "test").Meta("TEST").AddArgToList(&options.test_name_strs).Help("run test(s) matching TEST, a case-insensitive string");
18321834
p.AddOption('T', "test-pattern").Meta("TEST").AddArgToList(&test_name_patterns).Help("run test(s) matching TEST, a case-insensitive glob pattern");
18331835
p.AddOption('l', "list").SetIfPresent(&options.list).Help("list all test names");
@@ -1857,12 +1859,19 @@ static Options GetOptions(int argc, char *argv[]) {
18571859
}
18581860
}
18591861

1862+
if (options.verbose) {
1863+
printf("Regex: %s\n", test_name_regex_str.c_str());
1864+
}
1865+
1866+
std::regex re;
18601867
try {
1861-
options.test_name_regexes.push_back(std::regex(test_name_regex_str, std::regex_constants::icase | std::regex_constants::extended));
1868+
re = std::regex(std::regex(test_name_regex_str, std::regex_constants::icase | std::regex_constants::extended));
18621869
} catch (const std::regex_error &e) {
18631870
fprintf(stderr, "FATAL: error in regex: %s\nFATAL: %s\n", test_name_regex_str.c_str(), e.what());
18641871
exit(1);
18651872
}
1873+
1874+
options.test_name_regexes.push_back(std::move(re));
18661875
}
18671876

18681877
return options;

0 commit comments

Comments
 (0)