stm32l432 support

[geoffreymbrown]

Changes to support stm32l432

[xor-gate]

Looks good, except those two minor comment

[geoffreymbrown]

Ok. Do you want me to correct the whitespace ? Or is it easier for you to
handle ?
Geoffrey

On Sat, Oct 15, 2016 at 2:41 PM, Jerry Jacobs notifications@github.com
wrote:

@xor-gate requested changes on this pull request.

Looks good, except those two minor comment

In include/stlink/chipid.h
#501 (review):

@@ -54,6 +55,9 @@ enum stlink_stm32_chipids {
STLINK_CHIPID_STM32_F7 = 0x449,
STLINK_CHIPID_STM32_F7XXXX = 0x451,
STLINK_CHIPID_STM32_F410 = 0x458
+
+

Please dont add whitespaces

In src/chipid.c
#501 (review):

@@ -406,6 +406,22 @@ static const struct stlink_chipid_params devices[] = {
.bootrom_base = 0x1fff0000, // Tables 4-6, pages 80-81 (Bank 1 system memory)
.bootrom_size = 0x7000 // 28k (per bank), same source as base
},

•     {
  

•        //   STLINK_CHIPID_STM32_L43X
  

•        // From RM0392.
  

•     .chip_id = STLINK_CHIPID_STM32_L43X,
  

•        .description = "L4 device",
  

L43x device

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#501 (review), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABq_UmJvVJr5T7zKoLpdcM3Bvt8Aax4vks5q0R5AgaJpZM4KXx2L
.

[geoffreymbrown]

ok, I've pushed the changes -- looks like they show up in the pull request.
Geoffrey

On Sat, Oct 15, 2016 at 2:43 PM, Geoffrey Brown geoffreymbrown@gmail.com
wrote:

Ok. Do you want me to correct the whitespace ? Or is it easier for you
to handle ?
Geoffrey

On Sat, Oct 15, 2016 at 2:41 PM, Jerry Jacobs notifications@github.com
wrote:

@xor-gate requested changes on this pull request.

Looks good, except those two minor comment

In include/stlink/chipid.h
#501 (review):

@@ -54,6 +55,9 @@ enum stlink_stm32_chipids {
STLINK_CHIPID_STM32_F7 = 0x449,
STLINK_CHIPID_STM32_F7XXXX = 0x451,
STLINK_CHIPID_STM32_F410 = 0x458
+
+

Please dont add whitespaces

In src/chipid.c
#501 (review):

@@ -406,6 +406,22 @@ static const struct stlink_chipid_params devices[] = {
.bootrom_base = 0x1fff0000, // Tables 4-6, pages 80-81 (Bank 1 system memory)
.bootrom_size = 0x7000 // 28k (per bank), same source as base
},

•        {
  

•        //  STLINK_CHIPID_STM32_L43X
  

•        // From RM0392.
  

•    .chip_id = STLINK_CHIPID_STM32_L43X,
  

•        .description = "L4 device",
  

L43x device

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#501 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABq_UmJvVJr5T7zKoLpdcM3Bvt8Aax4vks5q0R5AgaJpZM4KXx2L
.

[xor-gate]

Yes all changes in a separate branch go into the same pull request. Thank you!