Skip to content

Omit leading slash when extracting entrypoint binary#2139

Merged
openshift-merge-bot[bot] merged 1 commit intomainfrom
sascha-omit-leading-slash
Mar 21, 2026
Merged

Omit leading slash when extracting entrypoint binary#2139
openshift-merge-bot[bot] merged 1 commit intomainfrom
sascha-omit-leading-slash

Conversation

@SaschaSchwarze0
Copy link
Member

Changes

gcr v0.21.3 changed the format of the tarball produced by crane export. Entries now do not start anymore with a slash (which is kind of recommended for tarballs).

This PR adapts the scripts we have that call crane export when scanning for release vulnerabilities by removing the leading slash of the entrypoint binary when extracting it from the tarball.

The action was failing since this run. I tested my changes in that run.

Type of PR

/kind bug

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Kind label has been set
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 20, 2026
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 20, 2026
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Mar 20, 2026
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.20.0 milestone Mar 20, 2026
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 60e8ff0 into main Mar 21, 2026
28 of 29 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the sascha-omit-leading-slash branch March 21, 2026 14:44
@github-project-automation github-project-automation bot moved this to Done in Issues Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants