Skip to content

Commit 1951f7c

Browse files
committed
Don't retry flakes in integration tests
Flaky behavior can hurt real users, and ignoring it to appease CI tests only hides the problem, and can make CI tests take longer. If this is too noisy, we can either spend effort fixing flakes, and/or make tests less strict, or re-enable flaky retries.
1 parent 6d8f56e commit 1951f7c

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

Makefile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ TEKTON_VERSION ?= v0.20.1
3333
SDK_VERSION ?= v0.17.0
3434

3535
# E2E test flags
36-
TEST_E2E_FLAGS ?= -failFast -flakeAttempts=2 -p -randomizeAllSpecs -slowSpecThreshold=300 -timeout=30m -progress -stream -trace -v
36+
TEST_E2E_FLAGS ?= -failFast -p -randomizeAllSpecs -slowSpecThreshold=300 -timeout=30m -progress -stream -trace -v
3737

3838
# E2E test operator behavior, can be start_local or managed_outside
3939
TEST_E2E_OPERATOR ?= start_local
@@ -219,7 +219,6 @@ test-integration: install-apis ginkgo
219219
-randomizeAllSpecs \
220220
-randomizeSuites \
221221
-failOnPending \
222-
-flakeAttempts=2 \
223222
-slowSpecThreshold=240 \
224223
-trace \
225224
test/integration/...

0 commit comments

Comments
 (0)