This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Update README.md with note on symlinks#405
Merged
lukastaegert merged 4 commits intomasterfrom Aug 22, 2019
Merged
Conversation
This addresses the confusion reported in #402 IMO it would be nice to make this easier on people by supporting includeModule/excludeModule, but in the meantime we should document symlinks a bit better.
shellscape
reviewed
Aug 20, 2019
shellscape
reviewed
Aug 20, 2019
Co-Authored-By: Andrew Powell <shellscape@users.noreply.github.com>
Contributor
Author
|
Thanks for the review @shellscape, I've taken your suggestions. |
shellscape
approved these changes
Aug 20, 2019
Prefer specifying module names over paths
Contributor
Author
|
@shellscape can you double check the latest commit? I think the docs should prefer the module name form for namedExports since it's easier and more reliable. |
lukastaegert
approved these changes
Aug 22, 2019
Member
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Looks good! Will merge this, but I guess this one does not require a dedicated release 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the confusion reported in #402
IMO it would be nice to make this easier on people by supporting includeModule/excludeModule, but in the meantime we should document symlinks a bit better.