This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Support preserveSymlinks: false (fixes #400)#401
Merged
lukastaegert merged 5 commits intorollup:masterfrom Aug 3, 2019
Merged
Conversation
Contributor
Author
|
I'm not sure why my test is failing in appveyor - it passes locally (on windows, in node 8, 10, and 12). Appreciate any thoughts on how to fix it while I ponder... The error is: |
Contributor
Author
|
Looks like the issue was that core.symlinks isn't enabled by default in git for windows. Once enabled, it looks like everything passes! 🎉 |
lukastaegert
approved these changes
Aug 3, 2019
|
|
||
| init: | ||
| - git config --global core.autocrlf false | ||
| - git config --global core.symlinks true |
Member
There was a problem hiding this comment.
Nice you found this! This could be useful for Rollup core as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if there is anything else required here!
Fixes #400.