This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Add "location" and "process" to reserved words#330
Merged
lukastaegert merged 2 commits intorollup:masterfrom Sep 18, 2018
Merged
Add "location" and "process" to reserved words#330lukastaegert merged 2 commits intorollup:masterfrom
lukastaegert merged 2 commits intorollup:masterfrom
Conversation
Currently you can generate code with satements like `var process = ` or `var location = ` this is obviously a bad Idea vor node (case 1) or the browser (case 2)
lukastaegert
approved these changes
Aug 9, 2018
Member
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Definitely makes sense! For a more general solution, maybe we actually want to include a curated list like https://www.npmjs.com/package/globals?
Member
|
Merging this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently you can generate code with satements like
var process =orvar location =this is obviously a bad Idea vor node (case 1) or the browser (case 2)
Resolves #309