This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Fix unnecessarily wrapping modules with return inside arrow functions#302
Merged
lukastaegert merged 5 commits intorollup:masterfrom Mar 12, 2018
Merged
Conversation
lukastaegert
reviewed
Mar 8, 2018
Member
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Awesome catch, thanks! Added one minor suggestion, otherwise I'd say this is good to go into the next release.
src/transform.js
Outdated
|
|
||
| if ( node.scope ) scope = node.scope; | ||
| if ( /^Function/.test( node.type ) ) lexicalDepth += 1; | ||
| if ( /Function/.test( node.type ) ) lexicalDepth += 1; |
Member
There was a problem hiding this comment.
Very minor improvement: If you extract the RegExp into a constant (outside the transform function), then performance will be slightly better as it only needs to be compiled once and we can reuse it for both occurrences .
Contributor
Author
|
Suggestion implemented. I also changed the test to cover all types of functions, instead of just arrow functions. |
Member
|
Published! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of the plugin incorrectly recognizes
returnstatements inside arrow functions as top-levelreturns. As such, it adds an unnecessary wrapper around the module.The bug is due to this line in transform.js:
The node type of an arrow function is
'ArrowFunctionExpression', which does not start with the wordFunction. 😛