This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Handle missing default export even if first pass matched#285
Merged
lukastaegert merged 1 commit intorollup:masterfrom Mar 5, 2018
Merged
Handle missing default export even if first pass matched#285lukastaegert merged 1 commit intorollup:masterfrom
lukastaegert merged 1 commit intorollup:masterfrom
Conversation
lukastaegert
approved these changes
Mar 5, 2018
| @@ -0,0 +1,2 @@ | |||
| // Great module | |||
Member
There was a problem hiding this comment.
Nice one! Took me some time to figure out what was going on here so I'll just write it down for future reference:
- The CJS plugin is first doing a quick regexp check to see if a module could be CJS. This check is just looking for keywords such as
module - If the check matches, the
transformfunction repeats this test using an actual AST - Modules that are not CJS specific were treated differently if the first or if the second check was successful. This is fixed by this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #255.