Skip to content

modify:#1435

Merged
zengyh1900 merged 1 commit intoopen-mmlab:masterfrom
liuky74:master
Nov 15, 2022
Merged

modify:#1435
zengyh1900 merged 1 commit intoopen-mmlab:masterfrom
liuky74:master

Conversation

@liuky74
Copy link

@liuky74 liuky74 commented Nov 14, 2022

Motivation

Fix errors in the TTSR configuration file

debug ttsr-rec config file
@LeoXing1996
Copy link
Collaborator

Hey @liuky74, thanks for your contribution. Can you provide screenshots of running the original config and your modification ones to verify your modification?

@liuky74
Copy link
Author

liuky74 commented Nov 14, 2022

Hey @liuky74, thanks for your contribution. Can you provide screenshots of running the original config and your modification ones to verify your modification?
of course, there is original config:
image

after modification:
image

@liuwenran
Copy link
Collaborator

liuwenran commented Nov 14, 2022

@LeoXing1996 , this pr comes from this issue
#1426

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 83.87% // Head: 83.90% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (6c4f6f8) compared to base (6e3315e).
Patch coverage: 97.67% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
+ Coverage   83.87%   83.90%   +0.03%     
==========================================
  Files         223      224       +1     
  Lines       12736    12771      +35     
  Branches     1990     1994       +4     
==========================================
+ Hits        10682    10716      +34     
- Misses       1715     1716       +1     
  Partials      339      339              
Flag Coverage Δ
unittests 83.90% <97.67%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/core/hooks/visualization.py 94.59% <83.33%> (-2.29%) ⬇️
mmedit/__init__.py 50.00% <100.00%> (ø)
mmedit/core/__init__.py 100.00% <100.00%> (ø)
mmedit/core/hooks/__init__.py 100.00% <100.00%> (ø)
mmedit/utils/__init__.py 100.00% <100.00%> (ø)
mmedit/utils/misc.py 100.00% <100.00%> (ø)
mmedit/version.py 58.33% <100.00%> (ø)
mmedit/datasets/pipelines/random_degradations.py 94.01% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zengyh1900 zengyh1900 merged commit d00a019 into open-mmlab:master Nov 15, 2022
@OpenMMLab-Assistant005
Copy link

Dear liuky74,
First of all, we want to express our gratitude for your significant PR in the MMEditing project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG
Thank you again for your contribution❤
Best regards! @liuky74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants