chore(release): change release script to append commits instead of re…#6
Merged
vsavkin merged 1 commit intonrwl:masterfrom Aug 31, 2017
Merged
chore(release): change release script to append commits instead of re…#6vsavkin merged 1 commit intonrwl:masterfrom
vsavkin merged 1 commit intonrwl:masterfrom
Conversation
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…place
To test:
edit release.sh and change this line:
git remote add origin git@github.com:nrwl/$REPO_DIR.git && \to point to your own fork of the builds, i.e.:
git@github.com:vsavkin/$REPO_DIR.gitThis makes our release script append commits to the respective build repositories, instead of replacing the init commit every time.
With this change, a version is created for each of the builds, which is nx's current package.json version plus the short sha for the current nx commit, i.e.
0.0.1-abcdef0. This version is used to update the built package.json version, and is also used to create a git tag on each of the respective repositories.Look at my forks of the builds to see the output: