add bazel schematics by vsavkin · Pull Request #1 · nrwl/nx

vsavkin · 2017-08-15T20:41:15Z

No description provided.

…by angular schematics

alexeagle · 2017-08-19T18:08:14Z

src/bazel/webpack.bzl

+        "srcs": attr.label_list(allow_files=True, aspects=[_collect_es5_sources]),
+        "config": attr.label(allow_single_file=True),
+        "mode": attr.string(default="dev"),
+        "_webpack": attr.label(default=Label("@build_bazel_rules_nrwl//:webpack"), executable=True, cfg="host")


the workspace name is supposed to be a reverse-DNS form
https://docs.bazel.build/versions/master/be/functions.html#workspace

on the other hand, for angular I'm planning to use the NPM namespace (even though this could conflict in theory) so my workspace name will be just @angular - perhaps you'd like this to be @nrwl

alexeagle · 2017-08-19T18:10:16Z

src/bazel/karma.conf.js

@@ -0,0 +1,107 @@
+module.exports = function(config) {


Add a warning comment about how the testing rule will change? (ppl might come browse this repo to find out what we are planning)

alexeagle · 2017-08-19T18:11:00Z

src/bazel/karma.conf.js

+      fixWebpackSourcePaths: true
+    },
+
+    client:{


you didn't run a formatter on this file?1?1111

alexeagle · 2017-08-19T18:11:19Z

src/bazel/karma.conf.js

+    browsers: ['Chrome'],
+
+    // globals: {
+    //   appPath: `${config.bin}/${config.app}`


remove comments?

alexeagle · 2017-08-19T18:11:56Z

src/bazel/template-loader.js

@@ -0,0 +1,30 @@
+var templateUrlRegex = /templateUrl\s*:(\s*['"`](.*?)['"`]\s*([,}]))/gm;


this file only used with karma, right? seems like there should be a karma subdirectory

alexeagle · 2017-08-19T18:20:24Z

src/schematics/app/index.ts

+function addBootstrap(path: string): Rule {
+  return (host: Tree) => {
+    const modulePath = `${path}/app/app.module.ts`;
+    const moduleSource = host.read(modulePath) !.toString('utf-8');


strange space there before non-null assertion - are you using a formatter?

alexeagle · 2017-08-19T18:22:03Z

src/schematics/workspace/files/BUILD.bazel__tmpl__

+load("@build_bazel_rules_angular//:defs.bzl", "ng_external_libraries")
+
+filegroup(name = "node_modules", srcs = glob([
+    # should not be whitelisted


can you change this block to

glob(["node_modules/**/*.js", "node_modules/**/*.json", "node_modules/**/*.d.ts"])

without breaking anything?

alexeagle · 2017-08-19T18:22:49Z

src/schematics/workspace/files/BUILD.bazel__tmpl__

+    "node_modules/@angular/platform-browser/animations*",
+    "node_modules/@angular/platform-browser/animations/**",
+
+    # Alex E?


this should go away soon when we do bootstrap codegen in the scripts.postinstall

alexeagle · 2017-08-19T18:23:08Z

src/schematics/workspace/files/README.md__tmpl__

@@ -0,0 +1,28 @@
+# <%= className %>
+
+This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version <%= version %>.


it needs to say EXPERIMENTAL BAZEL I think

alexeagle · 2017-08-19T18:23:40Z

src/schematics/workspace/files/__dot__bazelrc__tmpl__

@@ -0,0 +1,5 @@
+build --strategy=AngularTemplateCompile=standalone


can you keep the comments in this file so users have a clue what to change

- removes the `differentialLoading` build option - differential loading is always enabled for prod builds BEFORE (without ESM): Benchmark #1: nx build demo --prod Time (mean ± σ): 13.834 s ± 1.731 s [User: 11.817 s, System: 1.352 s] Range (min … max): 11.947 s … 16.015 s 10 runs AFTER (with ESM): Benchmark #1: nx build demo --prod Time (mean ± σ): 18.711 s ± 1.310 s [User: 12.172 s, System: 1.394 s] Range (min … max): 17.232 s … 20.770 s 10 runs

nx-cloud · 2020-10-01T13:53:04Z

Nx Cloud Report

We didn't find any information for the current pull request with the commit cbf0411.
Please make sure you set the NX_BRANCH environment variable in your CI pipeline.

Check the Getting started section to configure the app.

Sent with 💌 from NxCloud.

github-actions · 2023-03-21T15:09:25Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

vsavkin force-pushed the add_bazel_schematics branch 3 times, most recently from 3086556 to 2371cf1 Compare August 16, 2017 13:33

vsavkin mentioned this pull request Aug 16, 2017

Change init, build, and test to use bazel angular/angular-cli#7395

Merged

vsavkin force-pushed the add_bazel_schematics branch 4 times, most recently from 4b2916c to 727e854 Compare August 18, 2017 20:53

vsavkin added 9 commits August 19, 2017 10:12

update scripts to package and release the package

7a7da27

move schematics into a peer dependency

95c6855

update README

3b31d90

cleanup: remove unused file

40626bb

refactor: update addNgRxToModule schematic to use utilities provided …

86d861a

…by angular schematics

cleanup: clean up ast utils

5ee42f5

feat: add workspace schematic

acd1e75

feat: add app schematic

9d0b61b

feat: register the new schematics in collection.json

b3b3691

vsavkin force-pushed the add_bazel_schematics branch from 727e854 to 1f37752 Compare August 19, 2017 14:16

alexeagle approved these changes Aug 19, 2017

View reviewed changes

feat: add bazel build utils

66d1441

vsavkin force-pushed the add_bazel_schematics branch from 1f37752 to 66d1441 Compare August 23, 2017 14:39

vsavkin merged commit 12299fd into master Aug 23, 2017

vsavkin deleted the add_bazel_schematics branch June 19, 2019 20:36

FrozenPandaz mentioned this pull request Jun 28, 2019

Serverless (via AWS SAM) support? #1523

Closed

jaysoo mentioned this pull request Jan 2, 2020

use babel-jest instead of ts-jest when babel is used for compilation @nrwl/react #1720

Closed

mikel67 mentioned this pull request Feb 3, 2020

Jenkins CI - npx nx affected --target=build throws as error #2422

Closed

panraj01 mentioned this pull request Sep 9, 2020

nx e2e with Cypress triggers Unknown option: '--env' #3571

Closed

yharaskrik mentioned this pull request May 27, 2021

Jaybell/remove-irrelevant-paths-from-tsconfig-in-hash #5587

Closed

yharaskrik mentioned this pull request Jul 6, 2021

Setup build as a target dependency for test and use compiled assets in tests #6253

Closed

pan93412 added a commit to pan93412/nx that referenced this pull request Nov 29, 2021

docs(core): proofread nrwl#1

c5e8947

yharaskrik mentioned this pull request Feb 10, 2022

Jaybell/make buildable schematic #8916

Closed

ennovum mentioned this pull request May 2, 2022

ng g @nrwl/angular:application failing while running using externalSchematic on Windows machine #8253

Closed

nhhockeyplayer mentioned this pull request Jun 5, 2022

How to resolve "Circular dependency" in NRWL #2570

Closed

mandarini mentioned this pull request Mar 2, 2023

fix(js): integrate buildable bundler and compiler options #15376

Merged

github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add bazel schematics#1

add bazel schematics#1
vsavkin merged 10 commits intomasterfrom
add_bazel_schematics

vsavkin commented Aug 15, 2017

Uh oh!

alexeagle Aug 19, 2017

Uh oh!

alexeagle Aug 19, 2017

Uh oh!

alexeagle Aug 19, 2017

Uh oh!

alexeagle Aug 19, 2017

Uh oh!

alexeagle Aug 19, 2017

Uh oh!

alexeagle Aug 19, 2017

Uh oh!

alexeagle Aug 19, 2017

Uh oh!

alexeagle Aug 19, 2017

Uh oh!

alexeagle Aug 19, 2017

Uh oh!

alexeagle Aug 19, 2017

Uh oh!

nx-cloud bot commented Oct 1, 2020 •

edited

Loading

Uh oh!

github-actions bot commented Mar 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,30 @@
		var templateUrlRegex = /templateUrl\s:(\s['"`](.?)['"`]\s([,}]))/gm;

		@@ -0,0 +1,28 @@
		# <%= className %>

		This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version <%= version %>.

		@@ -0,0 +1,5 @@
		build --strategy=AngularTemplateCompile=standalone

Conversation

vsavkin commented Aug 15, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nx-cloud bot commented Oct 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Nx Cloud Report

Uh oh!

github-actions bot commented Mar 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nx-cloud bot commented Oct 1, 2020 •

edited

Loading