fix(core): throw when invalid config is provided for initiating project

Author: vsavkin

e2e/workspace/src/workspace.test.ts

@@ -44,6 +44,10 @@ describe('run-one', () => {
         `
     );
 
+    // configuration has to be valid for the initiating project
+    expect(() => runCLI(`build ${myapp} -c=invalid`)).toThrow();
+
+    // configuration doesn't have to exists for deps (here only the app has production)
     const buildWithDeps = runCLI(`build ${myapp} --with-deps --prod`);
     expect(buildWithDeps).toContain(`Running target "build" succeeded`);
     expect(buildWithDeps).toContain(`nx run ${myapp}:build:production`);

packages/cli/lib/parse-run-one-options.ts

@@ -17,6 +17,9 @@ export function parseRunOneOptions(
   const parsedArgs = yargsParser(args, {
     boolean: ['prod', 'help'],
     string: ['configuration', 'project'],
+    alias: {
+      c: 'configuration',
+    },
   });
 
   if (parsedArgs['help']) {
@@ -63,6 +66,7 @@ export function parseRunOneOptions(
   if (!targets || !targets[target]) return false;
 
   const res = { project, target, configuration, parsedArgs };
+  delete parsedArgs['c'];
   delete parsedArgs['configuration'];
   delete parsedArgs['prod'];
   delete parsedArgs['project'];

packages/workspace/src/command-line/print-affected.ts

@@ -45,6 +45,7 @@ function createTasks(
         target: nxArgs.target,
         configuration: nxArgs.configuration,
         overrides: overrides,
+        errorIfCannotFindConfiguration: false,
       })
   );
   const isYarn = basename(process.env.npm_execpath || 'npm').startsWith('yarn');

packages/workspace/src/tasks-runner/run-command.ts

@@ -9,6 +9,7 @@ import { NxArgs } from '@nrwl/workspace/src/command-line/utils';
 import { isRelativePath } from '../utils/fileutils';
 import { Hasher } from '../core/hasher/hasher';
 import { projectHasTargetAndConfiguration } from '../utils/project-graph-utils';
+import { output } from '../utils/output';
 
 type RunArgs = yargs.Arguments & ReporterArgs;
 
@@ -38,6 +39,7 @@ export async function runCommand<T extends RunArgs>(
       target: nxArgs.target,
       configuration: nxArgs.configuration,
       overrides: overrides,
+      errorIfCannotFindConfiguration: project.name === initiatingProject,
     });
   });
 
@@ -87,18 +89,20 @@ export async function runCommand<T extends RunArgs>(
   });
 }
 
-export interface TaskParams {
+interface TaskParams {
   project: ProjectGraphNode;
   target: string;
   configuration: string;
   overrides: Object;
+  errorIfCannotFindConfiguration: boolean;
 }
 
 export function createTask({
   project,
   target,
   configuration,
   overrides,
+  errorIfCannotFindConfiguration,
 }: TaskParams): Task {
   const config = projectHasTargetAndConfiguration(
     project,
@@ -107,6 +111,14 @@ export function createTask({
   )
     ? configuration
     : undefined;
+
+  if (errorIfCannotFindConfiguration) {
+    output.error({
+      title: `Cannot find configuration '${configuration}' for project '${project.name}'`,
+    });
+    process.exit(1);
+  }
+
   const qualifiedTarget = {
     project: project.name,
     target,
@@ -190,7 +202,10 @@ export function getRunner(
       },
     };
   } else {
-    throw new Error(`Could not find runner configuration for ${runner}`);
+    output.error({
+      title: `Could not find runner configuration for ${runner}`,
+    });
+    process.exit(1);
   }
 }