wip: support tool retry on timeout via idempotencyKey param in CallToolRequestParams#2338
Closed
Conversation
bdc7f27 to
f927d9a
Compare
f927d9a to
51b26e2
Compare
Contributor
|
Thanks for the PR. This adds Idempotency keys were deferred to a future SEP during SEP-1686 and assigned to the Transports WG (Nov 18 meeting notes). That SEP hasn't been filed yet. If you'd like to push this forward, the right place to start is a SEP in the spec repo. Happy to revisit here once there's a schema change to implement. If there's a SEP or discussion I've missed that covers this, feel free to link it and reopen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Issue:
idempotencyHinttotrueSolution:
idempotencyKeyattribute to theCallToolRequestParamsDTO that is populated when calling a toolmax_timeout_retriesto a value greater than 0, which triggers tool retry on timeout with the same idempotency keyHow Has This Been Tested?
Unit tests and demo code (temporarily committed)
Breaking Changes
Not breaking, by default, retry is not enabled (hence not breaking existing behaviour)
Types of changes
Checklist
WIP
Additional context
This is a rough implementation of what an
idempotencyKeyattribute could look like in the spec. This is not a PR ready to be merged, but just to demo what it could look like, to "add some color to the picture". This is part of an ongoing discussion in the#financial-services-wgto support idempotent tools.