Merged
Conversation
|
Maybe appveyor CI could be extracted into a separate PR to unblock the fix? |
|
@kewde Could you rerun tests? I think appveyor got Node 11 already. |
|
Any news? |
|
I hate this ignoring, maintener? |
appveyor doesn't have NodeJS 11 support yet
Collaborator
Author
|
@kibertoad rerunning. |
|
@kewde Node 11 passed, some other random failures happened. Probably needs to be triggered again (btw, you don't need comment for that, closing and reopening the PR does the trick) |
Collaborator
Author
|
@kibertoad I've merged the NodeJS 11 code and started the binary publishing process. |
Collaborator
Author
|
Still waiting for version 4.0.4 to be published to npm though. See #1077 |
|
Thanks |
Contributor
This is now done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.