fix: trigger release workflow on release published event#27
Merged
Conversation
CONTRIBUTING.md, .gitignore, and sharp stubs still had old naming from before the rebrand in PR #24. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
release-please creates tags via the GitHub API, which doesn't fire `on: push: tags` workflows when using the default GITHUB_TOKEN. Switch to `on: release: types: [published]` so binary builds run automatically after release-please creates a release. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on: push: tags: 'v*'toon: release: types: [published]github.event.release.tag_nameinstead ofgithub.ref_nameWhy
release-please creates tags via the GitHub API using the default
GITHUB_TOKEN, which doesn't fireon: push: tagsworkflows. This is why v1.3.0 has no binary assets.Test plan
bin/install.shsuccessfully downloads the binary🤖 Generated with Claude Code