feat(expect-expect): support chained function names (#471)

[folke]

Added support for chained assertion function names and method calls. (see also #471)

This makes it easy to support 3rd party assertion libraries like SuperTest with the option { "assertFunctionNames": ["expect", "request.get.expect"] }

Examples of correct code for deep assertion functions with the
{ "assertFunctionNames": ["expect", "tester.foo.expect"] } option:

/* eslint jest/expect-expect: ["error", { "assertFunctionNames": ["expect", "tester.foo.expect"] }] */
test('nested expect method call', () => {
  class Foo {
    expect(k) {
      return k;
    }
  }
  let tester = {
    foo: function() {
      return new Foo();
    },
  };
  tester.foo().expect(123);
});

[G-Rath]

Cheers, thanks for this!

[G-Rath]

Awesome cheers!

Now you just need to get coverage passing :)

[G-Rath]

Thanks!

[folke]

Fixing the coverage turned out to be trickier than expected, since getNodeName will almost never return null

Added (function(){})() as a test case for no-jasmine-globals.

Does the trick :)

[folke]

Thanks for reviewing and merging in the PR!! ✨

[github-actions]

🎉 This PR is included in version 23.4.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[G-Rath]

Fixing the coverage turned out to be trickier than expected

Interesting - I'll add a note to have a look into this as part of the maintenance run I have planned, just to make sure it's all good :)

Now that you've changed the implementation, it's possible that the overload signature should be tweaked, but regardless your fix here seems to work so that's the main thing :D