fix: remove package-name from release-please config#65
Merged
MoonBoi9001 merged 1 commit intomainfrom Nov 21, 2025
Merged
Conversation
Removes package-name field to ensure tags are created in v*.*.* format instead of rewards-eligibility-oracle-v*.*.* format. This allows the CD workflow to trigger correctly and build Docker images.
DaMandal0rian
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
package-namefield fromrelease-please-config.jsonto fix Docker image builds.Problem
The v0.4.2 release created a tag
rewards-eligibility-oracle-v0.4.2instead ofv0.4.2because of thepackage-nameconfiguration. The CD workflow only triggers on tags matchingv*.*.*, so no Docker image was built.Solution
Remove
package-namefrom the config. Future releases will create tags in the correct format (v*.*.*) that trigger the CD workflow and build Docker images.Impact
The next release (v0.4.3) will have the correct tag format and will automatically build and publish the Docker image.