feat(deno): more tests

Author: isaacs

packages/deno/src/utils/streaming.ts

@@ -1,3 +1,5 @@
+import { Span } from "@sentry/core";
+
 export type StreamingGuess = {
   isStreaming: boolean;
 };
@@ -39,3 +41,49 @@ export function classifyResponseStreaming(res: Response): StreamingGuess {
   // Default: treat as non-streaming
   return { isStreaming: false };
 }
+
+/**
+ * Tee a stream, and end the provided span when the stream ends.
+ * Returns the other side of the tee, which can be used to send the
+ * response to a client.
+ */
+export async function streamResponse(span: Span, res: Response): Promise<Response> {
+  const classification = classifyResponseStreaming(res);
+
+  // not streaming, just end the span and return the response
+  if (!classification.isStreaming || !res.body) {
+    span.end();
+    return res;
+  }
+
+  // Streaming response detected - monitor consumption to keep span alive
+  try {
+    // Monitor stream consumption and end span when complete
+    const [clientStream, monitorStream] = res.body.tee();
+    await (async () => {
+      const reader = monitorStream.getReader();
+      try {
+        let done = false;
+        while (!done) {
+          const result = await reader.read();
+          done = result.done;
+        }
+      } catch {
+        // Stream error or cancellation - will end span in finally
+      } finally {
+        reader.releaseLock();
+        span.end();
+      }
+    })();
+    // Return response with client stream
+    return new Response(clientStream, {
+      status: res.status,
+      statusText: res.statusText,
+      headers: res.headers,
+    });
+  } catch (e) {
+    // tee() failed - handle without streaming
+    span.end();
+    return res
+  }
+}

packages/deno/src/wrap-deno-request-handler.ts

@@ -13,7 +13,7 @@ import {
 } from '@sentry/core';
 import { init } from './sdk';
 import type { DenoOptions } from './types';
-import { classifyResponseStreaming } from './utils/streaming';
+import { streamResponse } from './utils/streaming';
 
 export type RequestHandlerWrapperOptions<Addr extends Deno.Addr> = {
   request: Request;
@@ -104,44 +104,7 @@ export const wrapDenoRequestHandler = <Addr extends Deno.Addr = Deno.Addr>(
             throw e;
           }
 
-          // Classify response to detect actual streaming
-          const classification = classifyResponseStreaming(res);
-          if (classification.isStreaming && res.body) {
-            // Streaming response detected - monitor consumption to keep span alive
-            try {
-              const [clientStream, monitorStream] = res.body.tee();
-
-              // Monitor stream consumption and end span when complete
-              await (async () => {
-                const reader = monitorStream.getReader();
-                try {
-                  let done = false;
-                  while (!done) {
-                    const result = await reader.read();
-                    done = result.done;
-                  }
-                } catch {
-                  // Stream error or cancellation - will end span in finally
-                } finally {
-                  reader.releaseLock();
-                  span.end();
-                }
-              })();
-
-              // Return response with client stream
-              return new Response(clientStream, {
-                status: res.status,
-                statusText: res.statusText,
-                headers: res.headers,
-              });
-            } catch (e) {
-              // tee() failed - fall through to non-streaming handling
-            }
-          }
-
-          // Non-streaming response - end span immediately and return original
-          span.end();
-          return res;
+          return streamResponse(span, res);
         });
       },
     );