Skip to content

Commit 7b0ae80

Browse files
logaretmclaude
logaretm
and
claude
committed
revert: Remove skip-sequence-0 optimization, keep always sending attribute
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 1cc231b commit 7b0ae80

File tree

15 files changed

+161
-63
lines changed

15 files changed

+161
-63
lines changed

‎dev-packages/browser-integration-tests/suites/public-api/logger/integration/test.ts‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
3434
'sentry.origin': { value: 'auto.log.console', type: 'string' },
3535
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
3636
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
37+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
3738
'sentry.message.template': { value: 'console.trace {} {}', type: 'string' },
3839
'sentry.message.parameter.0': { value: 123, type: 'integer' },
3940
'sentry.message.parameter.1': { value: false, type: 'boolean' },
@@ -49,6 +50,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
4950
'sentry.origin': { value: 'auto.log.console', type: 'string' },
5051
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
5152
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
53+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
5254
'sentry.message.template': { value: 'console.debug {} {}', type: 'string' },
5355
'sentry.message.parameter.0': { value: 123, type: 'integer' },
5456
'sentry.message.parameter.1': { value: false, type: 'boolean' },
@@ -64,6 +66,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
6466
'sentry.origin': { value: 'auto.log.console', type: 'string' },
6567
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
6668
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
69+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
6770
'sentry.message.template': { value: 'console.log {} {}', type: 'string' },
6871
'sentry.message.parameter.0': { value: 123, type: 'integer' },
6972
'sentry.message.parameter.1': { value: false, type: 'boolean' },
@@ -79,6 +82,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
7982
'sentry.origin': { value: 'auto.log.console', type: 'string' },
8083
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
8184
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
85+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
8286
'sentry.message.template': { value: 'console.info {} {}', type: 'string' },
8387
'sentry.message.parameter.0': { value: 123, type: 'integer' },
8488
'sentry.message.parameter.1': { value: false, type: 'boolean' },
@@ -94,6 +98,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
9498
'sentry.origin': { value: 'auto.log.console', type: 'string' },
9599
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
96100
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
101+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
97102
'sentry.message.template': { value: 'console.warn {} {}', type: 'string' },
98103
'sentry.message.parameter.0': { value: 123, type: 'integer' },
99104
'sentry.message.parameter.1': { value: false, type: 'boolean' },
@@ -109,6 +114,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
109114
'sentry.origin': { value: 'auto.log.console', type: 'string' },
110115
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
111116
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
117+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
112118
'sentry.message.template': { value: 'console.error {} {}', type: 'string' },
113119
'sentry.message.parameter.0': { value: 123, type: 'integer' },
114120
'sentry.message.parameter.1': { value: false, type: 'boolean' },
@@ -124,6 +130,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
124130
'sentry.origin': { value: 'auto.log.console', type: 'string' },
125131
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
126132
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
133+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
127134
},
128135
},
129136
{
@@ -136,6 +143,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
136143
'sentry.origin': { value: 'auto.log.console', type: 'string' },
137144
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
138145
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
146+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
139147
'sentry.message.template': { value: 'Object: {}', type: 'string' },
140148
'sentry.message.parameter.0': { value: '{"key":"value","nested":{"prop":123}}', type: 'string' },
141149
},
@@ -150,6 +158,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
150158
'sentry.origin': { value: 'auto.log.console', type: 'string' },
151159
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
152160
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
161+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
153162
'sentry.message.template': { value: 'Array: {}', type: 'string' },
154163
'sentry.message.parameter.0': { value: '[1,2,3,"string"]', type: 'string' },
155164
},
@@ -164,6 +173,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
164173
'sentry.origin': { value: 'auto.log.console', type: 'string' },
165174
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
166175
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
176+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
167177
'sentry.message.template': { value: 'Mixed: {} {} {} {}', type: 'string' },
168178
'sentry.message.parameter.0': { value: 'prefix', type: 'string' },
169179
'sentry.message.parameter.1': { value: '{"obj":true}', type: 'string' },
@@ -181,6 +191,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
181191
'sentry.origin': { value: 'auto.log.console', type: 'string' },
182192
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
183193
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
194+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
184195
},
185196
},
186197
{
@@ -193,6 +204,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
193204
'sentry.origin': { value: 'auto.log.console', type: 'string' },
194205
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
195206
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
207+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
196208
},
197209
},
198210
{
@@ -205,6 +217,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
205217
'sentry.origin': { value: 'auto.log.console', type: 'string' },
206218
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
207219
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
220+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
208221
},
209222
},
210223
{
@@ -217,6 +230,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
217230
'sentry.origin': { value: 'auto.log.console', type: 'string' },
218231
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
219232
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
233+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
220234
'sentry.message.template': { value: 'first {} {} {}', type: 'string' },
221235
'sentry.message.parameter.0': { value: 0, type: 'integer' },
222236
'sentry.message.parameter.1': { value: 1, type: 'integer' },
@@ -233,6 +247,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
233247
'sentry.origin': { value: 'auto.log.console', type: 'string' },
234248
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
235249
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
250+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
236251
'sentry.message.template': { value: 'hello {} {} {}', type: 'string' },
237252
'sentry.message.parameter.0': { value: true, type: 'boolean' },
238253
'sentry.message.parameter.1': { value: 'null', type: 'string' },

‎dev-packages/browser-integration-tests/suites/public-api/logger/scopeAttributes/test.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ sentryTest('captures logs with scope attributes', async ({ getLocalTestUrl, page
3232
attributes: {
3333
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
3434
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
35+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
3536
log_attr: { value: 'log_attr_1', type: 'string' },
3637
},
3738
},
@@ -44,6 +45,7 @@ sentryTest('captures logs with scope attributes', async ({ getLocalTestUrl, page
4445
attributes: {
4546
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
4647
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
48+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
4749
global_scope_attr: { value: true, type: 'boolean' },
4850
log_attr: { value: 'log_attr_2', type: 'string' },
4951
},
@@ -57,6 +59,7 @@ sentryTest('captures logs with scope attributes', async ({ getLocalTestUrl, page
5759
attributes: {
5860
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
5961
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
62+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
6063
global_scope_attr: { value: true, type: 'boolean' },
6164
isolation_scope_1_attr: { value: 100, unit: 'millisecond', type: 'integer' },
6265
log_attr: { value: 'log_attr_3', type: 'string' },
@@ -71,6 +74,7 @@ sentryTest('captures logs with scope attributes', async ({ getLocalTestUrl, page
7174
attributes: {
7275
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
7376
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
77+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
7478
global_scope_attr: { value: true, type: 'boolean' },
7579
isolation_scope_1_attr: { value: 100, unit: 'millisecond', type: 'integer' },
7680
scope_attr: { value: 200, unit: 'millisecond', type: 'integer' },
@@ -86,6 +90,7 @@ sentryTest('captures logs with scope attributes', async ({ getLocalTestUrl, page
8690
attributes: {
8791
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
8892
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
93+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
8994
global_scope_attr: { value: true, type: 'boolean' },
9095
isolation_scope_1_attr: { value: 100, unit: 'millisecond', type: 'integer' },
9196
scope_2_attr: { value: 300, unit: 'millisecond', type: 'integer' },

‎dev-packages/browser-integration-tests/suites/public-api/logger/simple/test.ts‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
3333
attributes: {
3434
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
3535
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
36+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
3637
},
3738
},
3839
{
@@ -44,6 +45,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
4445
attributes: {
4546
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
4647
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
48+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
4749
},
4850
},
4951
{
@@ -55,6 +57,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
5557
attributes: {
5658
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
5759
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
60+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
5861
},
5962
},
6063
{
@@ -66,6 +69,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
6669
attributes: {
6770
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
6871
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
72+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
6973
},
7074
},
7175
{
@@ -77,6 +81,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
7781
attributes: {
7882
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
7983
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
84+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
8085
},
8186
},
8287
{
@@ -88,6 +93,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
8893
attributes: {
8994
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
9095
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
96+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
9197
},
9298
},
9399
{
@@ -99,6 +105,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
99105
attributes: {
100106
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
101107
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
108+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
102109
'sentry.message.template': { value: 'test %s %s %s %s', type: 'string' },
103110
'sentry.message.parameter.0': { value: 'trace', type: 'string' },
104111
'sentry.message.parameter.1': { value: 'stringArg', type: 'string' },
@@ -115,6 +122,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
115122
attributes: {
116123
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
117124
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
125+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
118126
'sentry.message.template': { value: 'test %s %s %s %s', type: 'string' },
119127
'sentry.message.parameter.0': { value: 'debug', type: 'string' },
120128
'sentry.message.parameter.1': { value: 'stringArg', type: 'string' },
@@ -131,6 +139,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
131139
attributes: {
132140
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
133141
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
142+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
134143
'sentry.message.template': { value: 'test %s %s %s %s', type: 'string' },
135144
'sentry.message.parameter.0': { value: 'info', type: 'string' },
136145
'sentry.message.parameter.1': { value: 'stringArg', type: 'string' },
@@ -147,6 +156,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
147156
attributes: {
148157
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
149158
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
159+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
150160
'sentry.message.template': { value: 'test %s %s %s %s', type: 'string' },
151161
'sentry.message.parameter.0': { value: 'warn', type: 'string' },
152162
'sentry.message.parameter.1': { value: 'stringArg', type: 'string' },
@@ -163,6 +173,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
163173
attributes: {
164174
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
165175
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
176+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
166177
'sentry.message.template': { value: 'test %s %s %s %s', type: 'string' },
167178
'sentry.message.parameter.0': { value: 'error', type: 'string' },
168179
'sentry.message.parameter.1': { value: 'stringArg', type: 'string' },
@@ -179,6 +190,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
179190
attributes: {
180191
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
181192
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
193+
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
182194
'sentry.message.template': { value: 'test %s %s %s %s', type: 'string' },
183195
'sentry.message.parameter.0': { value: 'fatal', type: 'string' },
184196
'sentry.message.parameter.1': { value: 'stringArg', type: 'string' },

0 commit comments

Comments
 (0)