resolve conflicts

changing cache path

try coverage pattern

use commit hash in cache key

fix workflow syntax

add checkout to coverage

switch to artifacts

Update condition

change `if` syntax

switch condition

test

update

update

update

update

update

add grouping

skipif tests

update

temp

temp

update

remove temp

Author: aminalaee

.github/workflows/test-suite.yml

@@ -47,25 +47,25 @@ jobs:
 
     steps:
       - uses: "actions/checkout@v2"
-      - uses: actions/cache@v2
-        with:
-          path: .
-          key: ${{ runner.os }}-python${{ matrix.python-version }}
       - uses: "actions/setup-python@v1"
         with:
           python-version: "${{ matrix.python-version }}"
-          database-url: "${{ matrix.database-url }}"
       - name: "Install dependencies"
         run: "scripts/install"
       - name: "Run linting checks"
         run: "scripts/check"
       - name: "Build package & docs"
         run: "scripts/build"
       - name: "Run tests"
-        env: 
+        if: ${{ matrix.python-version != '3.6' || matrix.database-url != 'mysql+asyncmy://username:password@localhost:3306/testsuite' }}
+        env:
           TEST_DATABASE_URL: "${{ matrix.database-url }}"
-        if: ${{ matrix.python-version != '3.6' && matrix.database-url != 'mysql+asyncmy://username:password@localhost:3306/testsuite' }}
         run: "scripts/test"
+      - name: Upload code coverage results
+        uses: actions/upload-artifact@v2
+        with:
+          name: code-coverage-results
+          path: .coverage.*
 
   coverage:
     name: "Python ${{ matrix.python-version }}"
@@ -77,11 +77,12 @@ jobs:
         python-version: ["3.6", "3.7", "3.8", "3.9"]
 
     steps:
-      - uses: actions/cache@v2
+      - uses: "actions/checkout@v2"
+      - name: Download code coverage results
+        uses: actions/download-artifact@v2
         with:
-          path: .
-          key: ${{ runner.os }}-python${{ matrix.python-version }}
-      - name: test
-        run: "ls"
+          name: code-coverage-results
+      - name: "Install coverage.py"
+        run: "pip install coverage"
       - name: "Enforce coverage"
-        run: "./home/runner/work/databases/databases/scripts/coverage"
+        run: "./scripts/coverage"

tests/test_connection_options.py

@@ -1,14 +1,19 @@
 """
 Unit tests for the backend connection arguments.
 """
+import sys
+
+import pytest
 
 from databases.backends.aiopg import AiopgBackend
-from databases.backends.asyncmy import AsyncMyBackend
 from databases.backends.mysql import MySQLBackend
 from databases.backends.postgres import PostgresBackend
 from databases.core import DatabaseURL
 from tests.test_databases import DATABASE_URL, async_adapter
 
+if sys.version_info >= (3, 7):  # pragma: no cover
+    from databases.backends.asyncmy import AsyncMyBackend
+
 
 def test_postgres_pool_size():
     backend = PostgresBackend("postgres://localhost/database?min_size=1&max_size=20")
@@ -90,6 +95,7 @@ def test_mysql_pool_recycle():
     assert kwargs == {"pool_recycle": 20}
 
 
+@pytest.mark.skipif(sys.version_info < (3, 7), reason="requires python3.7 or higher")
 def test_asyncmy_pool_size():
     backend = AsyncMyBackend(
         "mysql+asyncmy://localhost/database?min_size=1&max_size=20"
@@ -98,24 +104,28 @@ def test_asyncmy_pool_size():
     assert kwargs == {"minsize": 1, "maxsize": 20}
 
 
+@pytest.mark.skipif(sys.version_info < (3, 7), reason="requires python3.7 or higher")
 def test_asyncmy_explicit_pool_size():
     backend = AsyncMyBackend("mysql://localhost/database", min_size=1, max_size=20)
     kwargs = backend._get_connection_kwargs()
     assert kwargs == {"minsize": 1, "maxsize": 20}
 
 
+@pytest.mark.skipif(sys.version_info < (3, 7), reason="requires python3.7 or higher")
 def test_asyncmy_ssl():
     backend = AsyncMyBackend("mysql+asyncmy://localhost/database?ssl=true")
     kwargs = backend._get_connection_kwargs()
     assert kwargs == {"ssl": True}
 
 
+@pytest.mark.skipif(sys.version_info < (3, 7), reason="requires python3.7 or higher")
 def test_asyncmy_explicit_ssl():
     backend = AsyncMyBackend("mysql+asyncmy://localhost/database", ssl=True)
     kwargs = backend._get_connection_kwargs()
     assert kwargs == {"ssl": True}
 
 
+@pytest.mark.skipif(sys.version_info < (3, 7), reason="requires python3.7 or higher")
 def test_asyncmy_pool_recycle():
     backend = AsyncMyBackend("mysql+asyncmy://localhost/database?pool_recycle=20")
     kwargs = backend._get_connection_kwargs()

tests/test_databases.py

@@ -16,11 +16,6 @@
 DATABASE_URL = os.environ["TEST_DATABASE_URL"]
 
 
-class AsyncMock(MagicMock):
-    async def __call__(self, *args, **kwargs):
-        return super(AsyncMock, self).__call__(*args, **kwargs)
-
-
 class AsyncMock(MagicMock):
     async def __call__(self, *args, **kwargs):
         return super(AsyncMock, self).__call__(*args, **kwargs)