Merge pull request #2990 from cpuguy83/fix_start_blocking

thaJeztah · web-flow · commit 19c5aab404c8 · 2021-05-07T08:32:48.000+02:00
Fix `docker start` blocking on signal handling
diff --git a/cli/command/container/start.go b/cli/command/container/start.go
@@ -75,7 +75,7 @@ func runStart(dockerCli command.Cli, opts *startOptions) error {
 		// We always use c.ID instead of container to maintain consistency during `docker start`
 		if !c.Config.Tty {
 			sigc := notfiyAllSignals()
-			ForwardAllSignals(ctx, dockerCli, c.ID, sigc)
+			go ForwardAllSignals(ctx, dockerCli, c.ID, sigc)
 			defer signal.StopCatch(sigc)
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ func runStart(dockerCli command.Cli, opts *startOptions) error {`
`75`	`75`	// We always use c.ID instead of container to maintain consistency during `docker start`
`76`	`76`	`if !c.Config.Tty {`
`77`	`77`	`sigc := notfiyAllSignals()`
`78`		`- ForwardAllSignals(ctx, dockerCli, c.ID, sigc)`
	`78`	`+ go ForwardAllSignals(ctx, dockerCli, c.ID, sigc)`
`79`	`79`	`defer signal.StopCatch(sigc)`
`80`	`80`	`}`
`81`	`81`