Skip to content

Commit 497a354

Browse files
authored
--generate-notes uses the commit graph, not semver ordering (#61)
Signed-off-by: Derek Misler <derek.misler@docker.com>
1 parent 90321c9 commit 497a354

File tree

5 files changed

+13
-7
lines changed

5 files changed

+13
-7
lines changed

.github/workflows/release.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@ jobs:
7575
done
7676
7777
echo "version=$NEW_VERSION" >> $GITHUB_OUTPUT
78-
echo "New version: $NEW_VERSION"
78+
echo "previous=${LATEST_TAG}" >> $GITHUB_OUTPUT
79+
echo "New version: $NEW_VERSION (previous: ${LATEST_TAG:-none})"
7980
8081
# CI cannot push commits to main (branch protection). Instead, we create
8182
# a detached release commit with pinned refs, reachable only via tags.
@@ -128,8 +129,14 @@ jobs:
128129
- name: Create GitHub Release
129130
env:
130131
VERSION: ${{ steps.version.outputs.version }}
132+
PREVIOUS: ${{ steps.version.outputs.previous }}
131133
GH_TOKEN: ${{ secrets.RELEASE_TOKEN }}
132-
run: gh release create "$VERSION" --generate-notes --latest
134+
run: |
135+
ARGS=(--generate-notes --latest)
136+
if [ -n "$PREVIOUS" ]; then
137+
ARGS+=(--notes-start-tag "$PREVIOUS")
138+
fi
139+
gh release create "$VERSION" "${ARGS[@]}"
133140
134141
- name: Update latest tag
135142
env:

.github/workflows/review-pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ jobs:
194194
manual-review:
195195
if: |
196196
github.event.issue.pull_request &&
197-
contains(github.event.comment.body, '/review') &&
197+
startsWith(github.event.comment.body, '/review') &&
198198
(github.event.comment.user.type != 'Bot' || github.event.comment.user.login == 'docker-agent[bot]')
199199
runs-on: ubuntu-latest
200200
env:

.github/workflows/self-review-pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ jobs:
105105
# Triggers when someone comments /review on a PR
106106
# ==========================================================================
107107
manual-review:
108-
if: github.event.issue.pull_request && contains(github.event.comment.body, '/review')
108+
if: github.event.issue.pull_request && startsWith(github.event.comment.body, '/review')
109109
runs-on: ubuntu-latest
110110
env:
111111
HAS_APP_SECRETS: ${{ secrets.CAGENT_REVIEWER_APP_ID != '' }}

action.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,6 @@ runs:
475475
exit 1
476476
fi
477477
echo "verbose-log-file=$VERBOSE_LOG_FILE" >> $GITHUB_OUTPUT
478-
echo "verbose-log-timestamp=$(date +%s%N)" >> $GITHUB_OUTPUT
479478
echo "Verbose log file: $VERBOSE_LOG_FILE"
480479
481480
# Build command arguments array (SECURE: no eval!)
@@ -702,7 +701,7 @@ runs:
702701
if: always() && steps.run-agent.outputs.verbose-log-file != ''
703702
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
704703
with:
705-
name: cagent-verbose-log-${{ github.run_id }}-${{ github.run_attempt }}-${{ steps.run-agent.outputs.verbose-log-timestamp }}
704+
name: cagent-verbose-log-${{ github.run_id }}-${{ github.run_attempt }}-${{ github.job }}
706705
path: ${{ steps.run-agent.outputs.verbose-log-file }}
707706
retention-days: 14
708707
if-no-files-found: ignore

review-pr/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ permissions:
125125
126126
jobs:
127127
review:
128-
if: github.event.issue.pull_request && contains(github.event.comment.body, '/review')
128+
if: github.event.issue.pull_request && startsWith(github.event.comment.body, '/review')
129129
runs-on: ubuntu-latest
130130
steps:
131131
- uses: actions/checkout@v4

0 commit comments

Comments
 (0)