Skip to content

Commit 11d0e3b

Browse files
committed
fix: skip memory save when review is locked, document lock release
- Guard "Save reviewer memory" with lock-check to prevent skipped runs from overwriting memory with stale data - Add comment explaining lock release failures are safe (TTL fallback)
1 parent 21812a1 commit 11d0e3b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

review-pr/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -650,7 +650,7 @@ runs:
650650

651651
- name: Release review lock
652652
if: always() && steps.lock-check.outputs.skip != 'true'
653-
continue-on-error: true
653+
continue-on-error: true # Release failures are safe — stale locks expire via TTL (2500s)
654654
shell: bash
655655
env:
656656
GH_TOKEN: ${{ steps.resolve-token.outputs.token }}
@@ -665,7 +665,7 @@ runs:
665665
echo "🔓 Released review lock for PR #$PR_NUMBER"
666666
667667
- name: Save reviewer memory
668-
if: always()
668+
if: always() && steps.lock-check.outputs.skip != 'true'
669669
continue-on-error: true # Don't fail if memory file doesn't exist (first run)
670670
uses: actions/cache/save@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
671671
with:

0 commit comments

Comments
 (0)