Skip to content

Commit 821c806

Browse files
committed
Apply suggestion from @jasnell
1 parent ac2af88 commit 821c806

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/workerd/api/node/tests/als-gc-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export const test = {
1212
if (!storeValue) {
1313
throw new Error(`Failed on attempt ${i}.`);
1414
}
15-
for (let j = 0; j < 100000; j++) {
15+
for (let j = 0; j < 1_000; j++) {
1616
(() => Math.random())();
1717
}
1818
}

src/workerd/jsg/async-context.c++

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,5 +186,8 @@ v8::Local<v8::Object> AsyncContextFrame::getJSWrapper(Lock& js) {
186186
return getJSWrapper(js.v8Isolate);
187187
}
188188

189-
void AsyncContextFrame::jsgVisitForGc(GcVisitor& visitor) {}
189+
void AsyncContextFrame::jsgVisitForGc(GcVisitor& visitor) {
190+
// tracing will make the members weak and will allow
191+
// them to be gc'd, which is not what we want.
192+
}
190193
} // namespace workerd::jsg

0 commit comments

Comments
 (0)