chore: delete junit3 reference (#11308) (#11771)

* chore: delete junit3 reference

- updated test to junit5
- delete dead code

* fix(ci): replace junit 3 dep by junit 5 dep

* fix(ci): replace junit 3 dep by junit 4 dep

* Remove reference for junit.framework.TestCas from test plugin

---------



(cherry picked from commit 9d675bb)

Signed-off-by: Sandra Parsick <sandra@parsick.dev>

Author: sparsick

compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/AbstractConflictResolverTest.java

@@ -69,11 +69,6 @@ public AbstractConflictResolverTest(String roleHint) throws Exception {
         this.roleHint = roleHint;
     }
 
-    // TestCase methods -------------------------------------------------------
-
-    /*
-     * @see junit.framework.TestCase#setUp()
-     */
     @BeforeEach
     public void setUp() throws Exception {
         conflictResolver = (ConflictResolver) container.lookup(ConflictResolver.ROLE, roleHint);

compat/maven-embedder/src/examples/simple-project/pom.xml

@@ -26,12 +26,12 @@ under the License.
   <name>simple-project</name>
   <url>http://maven.apache.org</url>
   <dependencies>
-    <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
-      <version>4.13.1</version>
-      <scope>test</scope>
-    </dependency>
+      <dependency>
+          <groupId>org.junit.jupiter</groupId>
+          <artifactId>junit-jupiter-api</artifactId>
+          <version>5.14.0</version>
+          <scope>test</scope>
+      </dependency>
   </dependencies>
   <properties>
     <environment>development</environment>

compat/maven-embedder/src/examples/simple-project/src/test/java/org/apache/maven/embedder/AppTest.java

@@ -19,39 +19,19 @@
 
 package org.apache.maven.embedder;
 
-import junit.framework.Test;
-import junit.framework.TestCase;
-import junit.framework.TestSuite;
-
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 /**
  * Unit test for simple App.
  */
-public class AppTest
-    extends TestCase
-{
-    /**
-     * Create the test case
-     *
-     * @param testName name of the test case
-     */
-    public AppTest( String testName )
-    {
-        super( testName );
-    }
+public class AppTest {
 
     /**
-     * @return the suite of tests being tested
+     * Rigourous Test :-)
      */
-    public static Test suite()
-    {
-        return new TestSuite( AppTest.class );
-    }
-
-    /**
-     * Rigorous Test :-)
-     */
-    public void testApp()
-    {
-        assertTrue( true );
+    @Test
+    public void testApp() {
+        assertTrue(true);
     }
 }
+

compat/maven-embedder/src/test/java/org/apache/maven/cli/props/MavenPropertiesTest.java

@@ -59,10 +59,6 @@ public class MavenPropertiesTest {
                 test=test
                 """;
 
-    /*
-     * (non-Javadoc)
-     * @see junit.framework.TestCase#setUp()
-     */
     @BeforeEach
     public void setUp() throws Exception {
         properties = new MavenProperties();

impl/maven-core/src/test/projects/lifecycle-executor/project-with-additional-lifecycle-elements/src/test/java/org/apache/maven/lifecycle/test/AppTest.java

@@ -1,38 +1,18 @@
 package org.apache.maven.lifecycle.test;
 
-import junit.framework.Test;
-import junit.framework.TestCase;
-import junit.framework.TestSuite;
-
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 /**
  * Unit test for simple App.
  */
-public class AppTest
-    extends TestCase
-{
-    /**
-     * Create the test case
-     *
-     * @param testName name of the test case
-     */
-    public AppTest( String testName )
-    {
-        super( testName );
-    }
+public class AppTest {
 
     /**
-     * @return the suite of tests being tested
+     * Rigourous Test :-)
      */
-    public static Test suite()
-    {
-        return new TestSuite( AppTest.class );
-    }
-
-    /**
-     * Rigorous Test :-)
-     */
-    public void testApp()
-    {
-        assertTrue( true );
+    @Test
+    public void testApp() {
+        assertTrue(true);
     }
 }
+

impl/maven-core/src/test/resources/apiv4-repo/org/codehaus/plexus/plexus-utils/1.0.4/plexus-utils-1.0.4.pom

@@ -212,7 +212,7 @@
     <dependency>
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>
-      <version>3.8.1</version>
+      <version>4.12</version>
       <scope>test</scope>
     </dependency>
   </dependencies>

its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2690MojoLoadingErrorsTest.java

@@ -60,7 +60,7 @@ public void testNoClassDefFromMojoLoad() throws IOException, VerificationExcepti
         int msg = indexOf(lines, "(?i).*required class is missing.*");
         assertTrue(msg >= 0, "User-friendly message was not found in output.");
 
-        int cls = lines.get(msg).toString().replace('/', '.').indexOf("junit.framework.TestCase");
+        int cls = lines.get(msg).toString().replace('/', '.').indexOf("org.apache.commons.lang3.StringUtils");
         assertTrue(cls >= 0, "Missing class name was not found in output.");
     }
 
@@ -80,7 +80,7 @@ public void testNoClassDefFromMojoConfiguration() throws IOException, Verificati
         int msg = indexOf(lines, "(?i).*required class (i|wa)s missing( during (mojo )?configuration)?.*");
         assertTrue(msg >= 0, "User-friendly message was not found in output.");
 
-        int cls = lines.get(msg).toString().replace('/', '.').indexOf("junit.framework.TestCase");
+        int cls = lines.get(msg).toString().replace('/', '.').indexOf("org.apache.commons.lang3.StringUtils");
         assertTrue(cls >= 0, "Missing class name was not found in output.");
     }
 

its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5640LifecycleParticipantAfterSessionEnd.java

@@ -56,7 +56,7 @@ public void testBuildFailureUTFail() throws Exception {
         verifier = newVerifier(projectDir.getAbsolutePath(), "remote");
         verifier.addCliArgument("package");
         assertThrows(VerificationException.class, verifier::execute, "The build should fail");
-        verifier.verifyTextInLog("testApp(org.apache.maven.its.mng5640.FailingTest)");
+        verifier.verifyTextInLog("testApp()");
 
         verifier.verifyFilePresent("target/afterProjectsRead.txt");
         // See https://issues.apache.org/jira/browse/MNG-5641

its/core-it-suite/src/test/resources/it0030/pom.xml

@@ -16,7 +16,7 @@
       <dependency>
         <groupId>junit</groupId>
         <artifactId>junit</artifactId>
-        <version>3.8.1</version>
+        <version>4.12</version>
       </dependency>
       <dependency>
         <groupId>org.apache.maven.its.it0030</groupId>