Skip to content

Commit abbf6c8

Browse files
author
Adrian Gonzalez-Martin
committed
Use default initialiser if not using a custom env (#1104)
1 parent 14c096d commit abbf6c8

File tree

5 files changed

+10
-0
lines changed

5 files changed

+10
-0
lines changed

mlserver/parallel/registry.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,12 @@ def model_initialiser(self, model_settings: ModelSettings) -> MLModel:
130130
# as normal.
131131
return model_initialiser(model_settings)
132132

133+
parameters = model_settings.parameters
134+
if not parameters or not parameters.environment_tarball:
135+
# If model is not using a custom environment, instantiate the model
136+
# as normal.
137+
return model_initialiser(model_settings)
138+
133139
# Otherwise, return a dummy model for now and wait for the load_model
134140
# hook to create the actual thing.
135141
# This avoids instantiating the model's actual class within the

runtimes/alibi-explain/tests/conftest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ async def model_registry(
115115
on_model_load=[inference_pool_registry.load_model],
116116
on_model_reload=[inference_pool_registry.reload_model],
117117
on_model_unload=[inference_pool_registry.unload_model],
118+
model_initialiser=inference_pool_registry.model_initialiser,
118119
)
119120

120121
await model_registry.load(custom_runtime_tf_settings)

runtimes/mlflow/tests/rest/conftest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ async def model_registry(
7171
on_model_load=[inference_pool_registry.load_model],
7272
on_model_reload=[inference_pool_registry.reload_model],
7373
on_model_unload=[inference_pool_registry.unload_model],
74+
model_initialiser=inference_pool_registry.model_initialiser,
7475
)
7576

7677
await model_registry.load(model_settings)

tests/grpc/conftest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ async def model_registry(
3737
on_model_load=[inference_pool_registry.load_model, load_batching],
3838
on_model_reload=[inference_pool_registry.reload_model],
3939
on_model_unload=[inference_pool_registry.unload_model],
40+
model_initialiser=inference_pool_registry.model_initialiser,
4041
)
4142

4243
model_name = sum_model_settings.name

tests/rest/conftest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ async def model_registry(
2222
on_model_load=[inference_pool_registry.load_model, load_batching],
2323
on_model_reload=[inference_pool_registry.reload_model],
2424
on_model_unload=[inference_pool_registry.unload_model],
25+
model_initialiser=inference_pool_registry.model_initialiser,
2526
)
2627

2728
model_name = sum_model_settings.name

0 commit comments

Comments
 (0)