Add better tracing and fix propagation of inDesiredState for PSAdapter#699
Merged
SteveL-MSFT merged 1 commit intoPowerShell:mainfrom Mar 17, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR updates the JSON key names used in logging to ensure proper trace level mapping and consistency.
- Converted JSON keys for error, warn, info, debug, and trace from uppercase to lowercase.
- Ensured the logger calls correctly use the lower-case keys as specified.
12b423a to
92c60fa
Compare
Member
Author
|
Need to make one more change to rename Edit: Actually, maybe we'll keep it as-is for now so there's no manipulation of the source |
tgauth
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
warninstead ofwarning_inDesiredStateproperty to the result object fortestif any of the results containInDesiredStateand only true if all are true